From d042ee0140760e231f6ccdce3026c9563f43b753 Mon Sep 17 00:00:00 2001 From: Scott Gasch Date: Fri, 23 Apr 2021 17:17:02 -0700 Subject: [PATCH] Rename a flag. --- ml_model_trainer.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ml_model_trainer.py b/ml_model_trainer.py index 7804d86..edddcc0 100644 --- a/ml_model_trainer.py +++ b/ml_model_trainer.py @@ -52,10 +52,10 @@ group.add_argument( help="Do not write a new model, just report efficacy.", ) group.add_argument( - "--ml_trainer_predicate", + "--ml_trainer_persist_threshold", type=argparse_utils.valid_percentage, metavar='0..100', - help="Persist the model if the test set score is >= this predicate.", + help="Persist the model if the test set score is >= this threshold.", ) @@ -69,7 +69,7 @@ class InputSpec(SimpleNamespace): basename: str dry_run: Optional[bool] quiet: Optional[bool] - persist_predicate: Optional[float] + persist_percentage_threshold: Optional[float] delete_bad_inputs: Optional[bool] @staticmethod @@ -77,7 +77,7 @@ class InputSpec(SimpleNamespace): return InputSpec( dry_run = config.config["ml_trainer_dry_run"], quiet = config.config["ml_trainer_quiet"], - persist_predicate = config.config["ml_trainer_predicate"], + persist_percentage_threshold = config.config["ml_trainer_persist_threshold"], delete_bad_inputs = config.config["ml_trainer_delete"], ) @@ -350,8 +350,8 @@ class TrainingBlueprint(ABC): model: Any) -> Tuple[Optional[str], Optional[str], Optional[str]]: if not self.spec.dry_run: if ( - (self.spec.persist_predicate is not None and - test_score > self.spec.persist_predicate) + (self.spec.persist_percentage_threshold is not None and + test_score > self.spec.persist_percentage_threshold) or (not self.spec.quiet and input_utils.yn_response("Write the model? [y,n]: ") == "y") -- 2.45.2