projects
/
python_utils.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
ea5adca
)
Rename a flag.
author
Scott Gasch
<
[email protected]
>
Sat, 24 Apr 2021 00:17:02 +0000
(17:17 -0700)
committer
Scott Gasch
<
[email protected]
>
Sat, 24 Apr 2021 00:17:02 +0000
(17:17 -0700)
ml_model_trainer.py
patch
|
blob
|
history
diff --git
a/ml_model_trainer.py
b/ml_model_trainer.py
index 7804d86b4744be0ee85ec1a5d0c6f113dd7030d2..edddcc0c9f794232a5d2ee6593793518abd2ef12 100644
(file)
--- a/
ml_model_trainer.py
+++ b/
ml_model_trainer.py
@@
-52,10
+52,10
@@
group.add_argument(
help="Do not write a new model, just report efficacy.",
)
group.add_argument(
help="Do not write a new model, just report efficacy.",
)
group.add_argument(
- "--ml_trainer_p
redicate
",
+ "--ml_trainer_p
ersist_threshold
",
type=argparse_utils.valid_percentage,
metavar='0..100',
type=argparse_utils.valid_percentage,
metavar='0..100',
- help="Persist the model if the test set score is >= this
predicate
.",
+ help="Persist the model if the test set score is >= this
threshold
.",
)
)
@@
-69,7
+69,7
@@
class InputSpec(SimpleNamespace):
basename: str
dry_run: Optional[bool]
quiet: Optional[bool]
basename: str
dry_run: Optional[bool]
quiet: Optional[bool]
- persist_p
redicate
: Optional[float]
+ persist_p
ercentage_threshold
: Optional[float]
delete_bad_inputs: Optional[bool]
@staticmethod
delete_bad_inputs: Optional[bool]
@staticmethod
@@
-77,7
+77,7
@@
class InputSpec(SimpleNamespace):
return InputSpec(
dry_run = config.config["ml_trainer_dry_run"],
quiet = config.config["ml_trainer_quiet"],
return InputSpec(
dry_run = config.config["ml_trainer_dry_run"],
quiet = config.config["ml_trainer_quiet"],
- persist_p
redicate = config.config["ml_trainer_predicate
"],
+ persist_p
ercentage_threshold = config.config["ml_trainer_persist_threshold
"],
delete_bad_inputs = config.config["ml_trainer_delete"],
)
delete_bad_inputs = config.config["ml_trainer_delete"],
)
@@
-350,8
+350,8
@@
class TrainingBlueprint(ABC):
model: Any) -> Tuple[Optional[str], Optional[str], Optional[str]]:
if not self.spec.dry_run:
if (
model: Any) -> Tuple[Optional[str], Optional[str], Optional[str]]:
if not self.spec.dry_run:
if (
- (self.spec.persist_p
redicate
is not None and
- test_score > self.spec.persist_p
redicate
)
+ (self.spec.persist_p
ercentage_threshold
is not None and
+ test_score > self.spec.persist_p
ercentage_threshold
)
or
(not self.spec.quiet
and input_utils.yn_response("Write the model? [y,n]: ") == "y")
or
(not self.spec.quiet
and input_utils.yn_response("Write the model? [y,n]: ") == "y")