X-Git-Url: https://wannabe.guru.org/gitweb/?a=blobdiff_plain;f=exec_utils.py;h=a440de5375c1546d0bf46835bc00ecada06b7d9d;hb=beac1437b595ed543595b12b81ab637d4737038a;hp=dcd30a2e937e271ffe75109c019b3b345fa5997d;hpb=b3ef553f4f30614b97e23f2d4ad6d6576ec57adf;p=python_utils.git

diff --git a/exec_utils.py b/exec_utils.py
index dcd30a2..a440de5 100644
--- a/exec_utils.py
+++ b/exec_utils.py
@@ -1,5 +1,7 @@
 #!/usr/bin/env python3
 
+"""Helper methods concerned with executing subprocesses."""
+
 import atexit
 import logging
 import os
@@ -9,7 +11,6 @@ import subprocess
 import sys
 from typing import List, Optional
 
-
 logger = logging.getLogger(__file__)
 
 
@@ -31,12 +32,12 @@ def cmd_showing_output(
         stderr=subprocess.PIPE,
         universal_newlines=False,
     ) as p:
-        sel.register(p.stdout, selectors.EVENT_READ)
-        sel.register(p.stderr, selectors.EVENT_READ)
+        sel.register(p.stdout, selectors.EVENT_READ)  # type: ignore
+        sel.register(p.stderr, selectors.EVENT_READ)  # type: ignore
         done = False
         while not done:
             for key, _ in sel.select():
-                char = key.fileobj.read(1)
+                char = key.fileobj.read(1)  # type: ignore
                 if not char:
                     sel.unregister(key.fileobj)
                     if len(sel.get_map()) == 0:
@@ -138,7 +139,7 @@ def cmd_in_background(command: str, *, silent: bool = False) -> subprocess.Popen
     def kill_subproc() -> None:
         try:
             if subproc.poll() is None:
-                logger.info(f'At exit handler: killing {subproc} ({command})')
+                logger.info('At exit handler: killing %s (%s)', subproc, command)
                 subproc.terminate()
                 subproc.wait(timeout=10.0)
         except BaseException as be: