Make logging_utils remove preexisting logging turds, fix a small bug.

[python_utils.git] / logging_utils.py

diff --git a/logging_utils.py b/logging_utils.py
index 20a57f7c953ff9474f58a7057d5c20ef757aae2e..ddea102d4b7d4a94ea98d87a5877d922431d8225 100644 (file)
--- a/logging_utils.py
+++ b/logging_utils.py
@@ -13,7 +13,6 @@ import os
 import random
 import sys
 from typing import Callable, Iterable, Mapping, Optional
-import warnings
 
 from overrides import overrides
 import pytz
@@ -147,7 +146,7 @@ cfg.add_argument(
 cfg.add_argument(
     '--logging_clear_preexisting_handlers',
     action=argparse_utils.ActionNoYes,
-    default=False,
+    default=True,
     help=(
         'Should logging code clear preexisting global logging handlers and thus insist that is ' +
         'alone can add handlers.  Use this to work around annoying modules that insert global ' +
@@ -524,9 +523,8 @@ def initialize_logging(logger=None) -> logging.Logger:
         f'Initialized global logging; default logging level is {level_name}.'
     )
     if config.config['logging_clear_preexisting_handlers'] and preexisting_handlers_count > 0:
-        msg = 'Logging cleared {preexisting_handlers_count} global handlers (--logging_clear_preexisting_handlers)'
+        msg = f'Logging cleared {preexisting_handlers_count} global handlers (--logging_clear_preexisting_handlers)'
         logger.warning(msg)
-        warnings.warn(msg)
     logger.debug(f'Logging format specification is "{fmt}"')
     if config.config['logging_debug_threads']:
         logger.debug('...Logging format spec captures tid/pid (--logging_debug_threads)')