Change locking boundaries for shared dict. Add a unit test.

[python_utils.git] / histogram.py

diff --git a/histogram.py b/histogram.py
index 0368376434c3579014cf97974e3e6e381f494872..a899fe9c60cde770eda49dcdd1dade1790e9ec08 100644 (file)
--- a/histogram.py
+++ b/histogram.py
@@ -15,6 +15,7 @@ class SimpleHistogram(Generic[T]):
 
     def __init__(self, buckets: List[Tuple[T, T]]):
         from math_utils import RunningMedian
+
         self.buckets = {}
         for start_end in buckets:
             if self._get_bucket(start_end[0]) is not None:
@@ -28,9 +29,9 @@ class SimpleHistogram(Generic[T]):
 
     @staticmethod
     def n_evenly_spaced_buckets(
-            min_bound: T,
-            max_bound: T,
-            n: int,
+        min_bound: T,
+        max_bound: T,
+        n: int,
     ) -> List[Tuple[T, T]]:
         ret = []
         stride = int((max_bound - min_bound) / n)
@@ -66,30 +67,32 @@ class SimpleHistogram(Generic[T]):
             all_true = all_true and self.add_item(item)
         return all_true
 
-    def __repr__(self,
-                 label_formatter='%10s') -> str:
+    def __repr__(self, label_formatter='%10s') -> str:
         from text_utils import bar_graph
+
         max_population: Optional[int] = None
         for bucket in self.buckets:
             pop = self.buckets[bucket]
             if pop > 0:
-                last_bucket_start = bucket[0]
+                last_bucket_start = bucket[0]  # beginning of range
             if max_population is None or pop > max_population:
-                max_population = pop
+                max_population = pop  # bucket with max items
+
         txt = ""
         if max_population is None:
             return txt
 
-        for bucket in sorted(self.buckets, key=lambda x : x[0]):
+        for bucket in sorted(self.buckets, key=lambda x: x[0]):
             pop = self.buckets[bucket]
             start = bucket[0]
             end = bucket[1]
             bar = bar_graph(
                 (pop / max_population),
-                include_text = False,
-                width = 58,
-                left_end = "",
-                right_end = "")
+                include_text=False,
+                width=58,
+                left_end="",
+                right_end="",
+            )
             label = f'{label_formatter}..{label_formatter}' % (start, end)
             txt += f'{label:20}: ' + bar + f"({pop/self.count*100.0:5.2f}% n={pop})\n"
             if start == last_bucket_start: