mypy clean

[kiosk.git] / google_news_rss_renderer.py

diff --git a/google_news_rss_renderer.py b/google_news_rss_renderer.py
index 9cf38767cfba62cb44c436c0e8a4bc25957e83c5..2faeff2d01a0a0361180a07d8e17496aaaad6be1 100644 (file)
--- a/google_news_rss_renderer.py
+++ b/google_news_rss_renderer.py
@@ -1,8 +1,8 @@
 #!/usr/bin/env python3
 
-from bs4 import BeautifulSoup
+from bs4 import BeautifulSoup  # type: ignore
 import re
-from typing import Dict, List
+from typing import Dict, List, Optional
 import xml
 
 import generic_news_rss_renderer
@@ -33,8 +33,11 @@ class google_news_rss_renderer(generic_news_rss_renderer.generic_news_rss_render
     def find_description(self, item: xml.etree.ElementTree.Element) -> str:
         descr = item.findtext("description")
         source = item.findtext("source")
-        if source is not None:
-            descr = descr + " (%s)" % source
+        if descr is not None:
+            if source is not None:
+                descr = descr + f" (source)"
+        else:
+            descr = ""
         return descr
 
     def munge_description_internal(self, descr: str) -> str:
@@ -52,7 +55,7 @@ class google_news_rss_renderer(generic_news_rss_renderer.generic_news_rss_render
         descr = str(soup)
         return self.munge_description_internal(descr)
 
-    def find_image(self, item: xml.etree.ElementTree.Element) -> str:
+    def find_image(self, item: xml.etree.ElementTree.Element) -> Optional[str]:
         return None
 
     def should_use_https(self) -> bool: