Let's be explicit with asserts; there was a bug in histogram

[python_utils.git] / directory_filter.py

diff --git a/directory_filter.py b/directory_filter.py
index b076badf25dff7e34e2358b3e45d52c49692a424..b057f85a1c8c728a497171a37c4a216db231ba30 100644 (file)
--- a/directory_filter.py
+++ b/directory_filter.py
@@ -55,7 +55,7 @@ class DirectoryFileFilter(object):
         assert file_utils.does_file_exist(filename)
         if mtime is None:
             mtime = file_utils.get_file_raw_mtime(filename)
-        assert mtime
+        assert mtime is not None
         if self.mtime_by_filename.get(filename, 0) != mtime:
             md5 = file_utils.get_file_md5(filename)
             logger.debug(f'Computed/stored {filename}\'s MD5 at ts={mtime} ({md5})')
@@ -112,7 +112,7 @@ class DirectoryAllFilesFilter(DirectoryFileFilter):
         assert file_utils.does_file_exist(filename)
         if mtime is None:
             mtime = file_utils.get_file_raw_mtime(filename)
-        assert mtime
+        assert mtime is not None
         if self.mtime_by_filename.get(filename, 0) != mtime:
             md5 = file_utils.get_file_md5(filename)
             self.mtime_by_filename[filename] = mtime
@@ -120,7 +120,7 @@ class DirectoryAllFilesFilter(DirectoryFileFilter):
             self.all_md5s.add(md5)
 
     def apply(self, item: Any, ignored_filename: str = None) -> bool:
-        assert not ignored_filename
+        assert ignored_filename is None
         self._update()
         mem_hash = hashlib.md5()
         mem_hash.update(item)