Logging is a good thing.

[kiosk.git] / chooser.py

diff --git a/chooser.py b/chooser.py
index 3514c976cb7c7149f539cefd25952d91fa97bf30..91746bdb3174067713fbe495e834a3e73bd78db9 100644 (file)
--- a/chooser.py
+++ b/chooser.py
@@ -8,9 +8,9 @@ import re
 import time
 from typing import Any, Callable, List, Optional, Set, Tuple
 
-import datetime_utils
+from pyutils.datetimes import datetime_utils
 
-import constants
+import kiosk_constants
 import trigger
 
 
@@ -29,8 +29,8 @@ class chooser(ABC):
         filenames = []
         pages = [
             f
-            for f in os.listdir(constants.pages_dir)
-            if os.path.isfile(os.path.join(constants.pages_dir, f))
+            for f in os.listdir(kiosk_constants.pages_dir)
+            if os.path.isfile(os.path.join(kiosk_constants.pages_dir, f))
         ]
         for page in pages:
             result = re.match(valid_filename, page)
@@ -38,17 +38,13 @@ class chooser(ABC):
                 if result.group(3) != "none":
                     freshness_requirement = int(result.group(3))
                     last_modified = int(
-                        os.path.getmtime(os.path.join(constants.pages_dir, page))
+                        os.path.getmtime(os.path.join(kiosk_constants.pages_dir, page))
                     )
                     age = now - last_modified
                     if age > freshness_requirement:
-                        logger.warning(
-                            f'chooser: "{page}" is too old.'
-                        )
+                        logger.warning(f'chooser: "{page}" is too old.')
                         continue
-                logger.info(
-                    f'chooser: candidate page: "{page}"'
-                )
+                logger.info(f'chooser: candidate page: "{page}"')
                 filenames.append(page)
         return filenames
 
@@ -69,17 +65,10 @@ class weighted_random_chooser(chooser):
         self.filter_list: List[Callable[[str], bool]] = []
         if filter_list is not None:
             self.filter_list.extend(filter_list)
-        self.filter_list.append(self.dont_choose_page_twice_in_a_row_filter)
-
-    def dont_choose_page_twice_in_a_row_filter(self, choice: str) -> bool:
-        if self.last_choice is not None and choice == self.last_choice:
-            return False
-        self.last_choice = choice
-        return True
 
     def choose_next_page(self) -> Any:
         if self.pages is None or self.count % 100 == 0:
-            logger.info('chooser: refreshing the candidate pages list.')
+            logger.info("chooser: refreshing the candidate pages list.")
             self.pages = self.get_page_list()
 
         total_weight = 0
@@ -137,28 +126,28 @@ class weighted_random_chooser_with_triggers(weighted_random_chooser):
             if x is not None and len(x) > 0:
                 for y in x:
                     self.page_queue.add(y)
-                    logger.info(f'chooser: noticed active trigger {y}')
+                    logger.info(f"chooser: noticed active trigger {y}")
                     triggered = True
         return triggered
 
     def choose_next_page(self) -> Tuple[str, bool]:
         if self.pages is None or self.count % 100 == 0:
-            logger.info('chooser: refreshing the candidates page list')
+            logger.info("chooser: refreshing the candidates page list")
             self.pages = self.get_page_list()
 
         triggered = self.check_for_triggers()
 
         # First try to satisfy from the page queue.
         if len(self.page_queue) > 0:
-            logger.info('chooser: page queue has entries; pulling choice from there.')
+            logger.info("chooser: page queue has entries; pulling choice from there.")
             page = None
             priority = None
             for t in self.page_queue:
                 if priority is None or t[1] > priority:
                     page = t[0]
                     priority = t[1]
-            assert(page is not None)
-            assert(priority is not None)
+            assert page is not None
+            assert priority is not None
             self.page_queue.remove((page, priority))
             return (page, triggered)