From ba95f45a6fd7e2ff26f820961fcb623ce317424f Mon Sep 17 00:00:00 2001 From: Scott Gasch Date: Sun, 26 Feb 2023 09:34:12 -0800 Subject: [PATCH] Fix logger.exception messages in example code. --- examples/cron/cron.py | 11 +++++------ examples/reminder/reminder.py | 5 ++--- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/examples/cron/cron.py b/examples/cron/cron.py index 6e0667d..db91af1 100755 --- a/examples/cron/cron.py +++ b/examples/cron/cron.py @@ -94,10 +94,10 @@ def run_command(timeout: Optional[int], timestamp_file: Optional[str]) -> int: logger.debug("Touching %s", timestamp_file) file_utils.touch_file(timestamp_file) return ret - except Exception as e: - logger.exception(e) + except Exception: + msg = "Cron subprocess failed; giving up." + logger.exception(msg) print("Cron subprocess failed, giving up.", file=sys.stderr) - logger.warning("Cron subprocess failed, giving up") return -1000 @@ -170,10 +170,9 @@ def main() -> int: file=wf, ) return retval - except lockfile.LockFileException as e: - logger.exception(e) + except lockfile.LockFileException: msg = f"Failed to acquire {lockfile_path}, giving up." - logger.error(msg) + logger.exception(msg) print(msg, file=sys.stderr) return 1000 else: diff --git a/examples/reminder/reminder.py b/examples/reminder/reminder.py index a7ed8e7..5fbd476 100755 --- a/examples/reminder/reminder.py +++ b/examples/reminder/reminder.py @@ -172,10 +172,9 @@ class Reminder(object): else: self.handle_event_with_fixed_year(orig_date, label) - except Exception as e: + except Exception: + logger.exception("Skipping malformed line: %s", line) print(f"Skipping unparsable line: {line}", file=sys.stderr) - logger.error("Skipping malformed line: %s", line) - logger.exception(e) def remind( self, count: Optional[int], days_ahead: Optional[int], say_date: bool -- 2.46.0